Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-37408] Update all docker-compose references to docker compose #26239

Merged
merged 2 commits into from
Mar 28, 2025
Merged

[FLINK-37408] Update all docker-compose references to docker compose #26239

merged 2 commits into from
Mar 28, 2025

Conversation

nilmadhab
Copy link
Contributor

@nilmadhab nilmadhab commented Mar 2, 2025 •
edited
Loading

What is the purpose of the change

Replace all instances of "docker-compose" with "docker compose" throughout the Flink documentation to align with Docker's current CLI naming convention.

https://issues.apache.org/jira/browse/FLINK-37408

Brief change log

Replace all instances of "docker-compose" with "docker compose" throughout the Flink documentation

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: ( no )

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? ( not applicable )

@nilmadhab nilmadhab changed the title Update all docker-compose references to docker compose [FLINK-37408] Update all docker-compose references to docker compose Mar 2, 2025
@nilmadhab nilmadhab marked this pull request as ready for review March 2, 2025 10:05
@nilmadhab nilmadhab mentioned this pull request Mar 2, 2025
Closed
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 2, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@nilmadhab
Copy link
Contributor Author

@flinkbot run azure

@nilmadhab
Copy link
Contributor Author

@davidradl any update here ?

@nilmadhab
Copy link
Contributor Author

@davidradl can you please look at it and approve?

@nilmadhab
Copy link
Contributor Author

@dawidwys @Zakelly @rmetzger can we merge this?

@ferenc-csaky
Copy link
Contributor

Thank you for this change, will merge this by today EOD (CET) if no objections until then.

@ferenc-csaky ferenc-csaky merged commit 354e0e4 into apache:master Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferenc-csaky ferenc-csaky ferenc-csaky approved these changes

@davidradl davidradl davidradl approved these changes

Assignees
No one assigned
Labels
component=<none>
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nilmadhab @flinkbot @ferenc-csaky @davidradl